Replacing DatePicker with Design Systems Date Input components #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgaDufrat
reviewed
Jul 11, 2024
AgaDufrat
reviewed
Jul 11, 2024
AgaDufrat
reviewed
Jul 11, 2024
AgaDufrat
reviewed
Jul 11, 2024
PeterHattyar
force-pushed
the
replacing-date-picker
branch
2 times, most recently
from
a261071
to
59ae29c
Compare
PeterHattyar
force-pushed
the
replacing-date-picker
branch
2 times, most recently
from
bcbb4bb
to
ce25f4c
Compare
PeterHattyar
force-pushed
the
replacing-date-picker
branch
2 times, most recently
from
49cb85a
to
1e9105e
Compare
PeterHattyar
force-pushed
the
replacing-date-picker
branch
from
1e9105e
to
d4f16b0
Compare
PeterHattyar
changed the title
It will be used in the forms which have a date input field.
Added modification so the design system elements replacing datepicker are rendered in the correct relevant style on their respective views.
Date picker arrows in Support app stopped working after the migration to Dart Sass. It’s caused by a known issue in the way Dart Sass handles the icon as Unicode - sass/sass#1395 we were not able to find a workaround. Date picker are not very accessible. When users are filling the dates in the form they normally know them already (and don’t need to pick it by looking at a calendar). Users see a symbol instead of an arrow. There’s alt text (Next, Prev). It’s also possible to enter date manually. This will allow us to drop dependency on jquery-ui-rails. Due to delivery priorities, we're not converting the entire form into Design System at the moment.
Date picker arrows in Support app stopped working after the migration to Dart Sass. It’s caused by a known issue in the way Dart Sass handles the icon as Unicode - sass/sass#1395 we were not able to find a workaround. Date picker are not very accessible. When users are filling the dates in the form they normally know them already (and don’t need to pick it by looking at a calendar). Users see a symbol instead of an arrow. There’s alt text (Next, Prev). It’s also possible to enter date manually. This will allow us to drop dependency on jquery-ui-rails. Due to delivery priorities, we're not converting the entire form into Design System at the moment.
PeterHattyar
force-pushed
the
replacing-date-picker
branch
from
d4f16b0
to
5bbe95a
Compare
MuriloDalRi
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
GitHub Issue: #1421
Replace date picker in the following forms:
“Request a new campaign”
“Remove user”
“Content change request”
“Content advice and help”
in Support app to use Design System date format: https://design-system.service.gov.uk/patterns/dates/ (separate fields for day, month, year). Add relevant validations.
NB: we are not converting the forms to Design System
Why
Date picker arrows in Support app stopped working after the migration to Dart Sass. It’s caused by a known issue in the way Dart Sass handles the icon as Unicode - sass/sass#1395 we were not able to find a workaround. Date picker are not very accessible. When users are filling the dates in the form they normally know them already (and don’t need to pick it by looking at a calendar).
Users see a symbol instead of an arrow. There’s alt text (Next, Prev). It’s also possible to enter date manually.
Before:
After:
Closes #1421