Add govuk repo tags check #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahh yes, how did I miss that?! |
Checks wether repos have been tagged correctly. This code was in the govuk-saas-config which is in the process of being retired.
MuriloDalRi
force-pushed
the
validate-repos
branch
from
c629ddf
to
e0fb1b6
Compare
|
@AgaDufrat I've added the tests now |
AgaDufrat
approved these changes
Aug 19, 2024
| .org_repos("alphagov", accept: "application/vnd.github.mercy-preview+json") | ||
| .select { |repo| repo.topics.to_a.include?("govuk") } | ||
| .reject(&:archived) | ||
| .reject { |repo| ignored_repos.include?(repo.full_name) } |
There was a problem hiding this comment.
The original FetchRepos class was used by both repo tags check and a script that configured GitHub. The exclusion of ignored_repos in the original code was used only by GitHub configuration script. The original govuk repo tags check didn't have ignore list.
We still want to be notified if licensify doesn't have govuk tag or if it's removed from the repos.json but still tagged.
I think we can ignore them for now, as there are some other considerations related to the "Deploy out of sync" alerting, which don't appear to be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks wether repos have been tagged correctly.
This code was in the govuk-saas-config which is in the process of being retired.
#559