add instructions_to_publishers to schemas
#2972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add a field to all Content Blocks that will be a short string containing an internal-only message. This adds the field `instructions_for_publishers` to a shared default schema file, and then sets it as optional on content blocks. Although this is a Content Block specific field, it did not make sense to include it in the `details` object because we are using that schema for all custom public-facing fields on a block. We have already set precedent for adding Content Block specific top level fields with `content_id_alias`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add a field to all Content Blocks that
will be a short string containing an internal-only message.
This adds the field
instructions_for_publishersto a shared default schema file, and then sets it
as optional on content blocks.
Although this is a Content Block specific field,
it did not make sense to include it in the
detailsobject because we are using that schemafor all custom public-facing fields on a block. We have already set precedent for adding Content
Block specific top level fields with
content_id_alias.This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.