Add mock finder #2832
Draft
Add mock finder #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraghiorghisor-tw
force-pushed
the
generalize-schema-spike
branch
3 times, most recently
from
1605832
to
8c0c839
Compare
lauraghiorghisor-tw
force-pushed
the
generalize-schema-spike
branch
from
8c0c839
to
e70e389
Compare
At the moment it is incredibly tedious to maintain the vast amount of document types and their facets for specialist documents. Unsure there is a lot of value in having these strict schema validations when a more relaxed one that doesn't check "valid values" for each field should be enough. This proof of concept works for publishing a specialist document. NOTE: for the sake of spike, the schemas have been directly manipulated to remove the enum for "document_type". if build schemas is rerun, we will lose this configuration. NOTE 2: another option is to remove enums entirely for document type across all schemas - this will also save us from having to add it to content_schemas/allowed_document_types.yml and content_schemas/formats/specialist_document.jsonnet . The question will then be whether or not that swings too far the other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mock finder for spike]