Temporarily remove WAF configuration #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some complexities around defining regions on WAFs for CloudFront resources, and it's unclear from the docs where these apply to API gateways in the edge mode. Removing temporarily to get the API gateway deploying properly.
It's recommended to have a [separate definition for the stage and deployment.](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/api_gateway_deployment#stage_name)
sihugh
force-pushed
the
api-gateway-for-search
branch
from
e045e8d
to
e92032a
Compare
sihugh
changed the title
richardTowers
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some complexities around defining regions on WAFs for CloudFront resources, and it's unclear from the docs where these apply to API gateways in the edge mode. Removing temporarily to get the API gateway deploying properly.
Also It's recommended to have a separate definition for the stage and deployment, so have split that out.