Add a spec for the Content Object Store #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-object-store-specs
branch
from
2a5f229
to
a827f24
Compare
Comment on lines
+81
to
+84
| page, | ||
| await page.getByRole("link", { name: "View on website" }).getAttribute("href") |
There was a problem hiding this comment.
Hmmm it's a shame there's not a why to write the test where we just click on the link instead.
There was a problem hiding this comment.
Yeah, it's annoying. I think the issue is there's latency between when we send the document to be published and when it actually gets published. Additionally, if we keep trying to click the link, the page gets cached from the first visit, so we need to add a cachebust param to the URL to force the reload 😞
pezholio
force-pushed
the
content-object-store-specs
branch
from
a827f24
to
fbc486c
Compare
pezholio
force-pushed
the
content-object-store-specs
branch
from
fbc486c
to
6f15098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple test (broken down into Steps) to do an end-to-end test of the basic functionality in the Content Object Store.
Controversially, it does alter state, but is much more stable that similar tests written for Smokey. However, as it accumulates state and is not hidden from the public, it should not be used in any environment other than integration.
I've also added a
waitForUrlToBeAvailablehelper function that polls a URL (with a cache-busting query string) to wait for it to exist before continuing.Hopefully this should be a useful proof of concept of a test that alters state.