Fix Windows job cancellation and stabilize Cursor pipe test - #379
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows local runs now enter a native Job Object before their launcher starts, so cancellation terminates the whole tree and remains available to a separate supervisor. Existing runs retain the previous cancellation path. Completed exit codes are preserved.
The Cursor stdin test keeps its Windows
.cmdlauncher but uses Git Bashcatinstead of starting PowerShell. The original timeout reproduced in 1 of 3 Windows runs with 16 test threads; a separate startup probe demonstrated children surviving the oldtaskkill /Tcancellation. Lifecycle tests now use UUID scratch directories so reused process IDs cannot pick up stale exit codes.Verification: