Preprocessing #337
Preprocessing #337
Conversation
…al in InternalRule
…al in InternalRule
# Conflicts: # alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/grounder/NaiveGrounder.java # alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/programs/transformation/SimplePreprocessing.java
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
============================================
+ Coverage 70.23% 71.01% +0.78%
- Complexity 2123 2192 +69
============================================
Files 182 183 +1
Lines 8023 8132 +109
Branches 1423 1455 +32
============================================
+ Hits 5635 5775 +140
+ Misses 2028 1976 -52
- Partials 360 381 +21 ☔ View full report in Codecov by Sentry. |
alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/grounder/NaiveGrounder.java
Outdated
Show resolved
Hide resolved
| * Gebser, M., Kaufmann, B., Neumann, A., & Schaub, T. (2008, June). Advanced Preprocessing for Answer Set Solving. | ||
| * In ECAI (Vol. 178, pp. 15-19). | ||
| */ | ||
|
|
| * solvers, as seen in: | ||
| * Gebser, M., Kaufmann, B., Neumann, A., & Schaub, T. (2008, June). Advanced Preprocessing for Answer Set Solving. | ||
| * In ECAI (Vol. 178, pp. 15-19). | ||
| */ |
There was a problem hiding this comment.
| */ | |
| * @see <a href="https://doi.org/10.3233/978-1-58603-891-5-15">doi:10.3233/978-1-58603-891-5-15</a> | |
| */ |
There was a problem hiding this comment.
Thanks for the suggestion, I changed the reference to the link.
| * Returns a copy of the rule with the specified literal removed, or null if the new rule would have an empty body. | ||
| * @return the rule without the specified literal, null if no body remains. | ||
| */ | ||
| public InternalRule returnCopyWithoutLiteral(Literal literal) { |
There was a problem hiding this comment.
Is there a particular reason to stress "return" here?
| public InternalRule returnCopyWithoutLiteral(Literal literal) { | |
| public InternalRule copyWithoutLiteral(Literal literal) { |
There was a problem hiding this comment.
No real reason, so it could be changed. But more importantly this is one of a few changes that I meant to revert but overlooked. Now this method is implemented within the SimplePreprocessing class.
I have now looked over all changed files and hopefully removed all unnecessary changes.
* doc: Add ConfWS21 paper to README Co-authored-by: Richard Taupe <[email protected]>
… of interval term
Link to "A coder's guide to answer set programming" from README.md
Fix SimpleLogger time format
Improve logging output for debugging.
…al in InternalRule
…al in InternalRule
…to preprocessing
This PR aims to implement the preprocessing techniques suggested in #114 .
So far only elementary simplifications have been added as a program transformation, with a command line option to disable them (dpp).
The viability of more sophisticated simplifications, using equivalence classes, in a lazy grounding setting is still being explored.