Reconcile mode and metrics #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add initial support for reconcile modes. Users could choose how the operator should behave their resources. The current implementation is inspired by Kubernetes Addon manager, Crossplane and other operators in the open source field.
The other thing in the PR is about metrics. The operator was going with event based metrics which is quite OK but that requires state & event management for the metrics otherwise if the operator restarts the metrics will be flushed and inappropriate. The metrics has been updated to metrics worker that evaluates the metrics based on the Custom Resources. Event based metrics could be added on future but for now I'll use the interval.