Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove insurance in cart when deactivated #569

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

Change state insurance product according insurance config state
Delete insurance product in cart if insurance is disable

How to test

As a reviewer, you are encouraged to test the PR locally.

Add insurance product in cart
Disable insurance in the configuration
See the insurance product is disable in the product list in back office
See the insurance product is deleted in the same cart

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

feat: WIP remove insurance product in cart and association

feat: WIP continue delete insurance product in cart if insurance is desabled

feat: WIP remove insurance product

feat: WIP delete insurance product if insurance config is disabled

feat: Remove insurance in cart when deactivated
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma force-pushed the feature/ecom-2003-ps-remove-insurance-in-cart-when-deactivated branch from 219c93f to ea78820 Compare September 30, 2024 15:37
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as ready for review September 30, 2024 15:37
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner September 30, 2024 15:37
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit ae2939e into develop Oct 1, 2024
4 of 6 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/ecom-2003-ps-remove-insurance-in-cart-when-deactivated branch October 1, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants