feature : Add hmac validation to IPN controller #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-Freoua-Alma
approved these changes
Sep 17, 2024
webaaz
reviewed
Sep 19, 2024
src/app/code/community/Alma/Installments/Model/Exceptions/PaymentException.php
Outdated
Show resolved
Hide resolved
src/app/code/community/Alma/Installments/controllers/PaymentController.php
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/almapay/issue/ECOM-1823/[-magento1]-add-hmac-verification-on-ipn
Add verification signature in IPN action.
How to test :
Must be tested in QA env !
Create a product and set Alma test & live key
Create a paiement and check ipn logs in Alma dashbord
Use this payment id to check ipn on route :
{baseURL}alma/payment/ipn?pid={paymentId}
without signature header and with a bad signature.
No unit test on magento 1 for the moment.