Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transactions): encode eip1559 #45

Merged
merged 8 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ use_self = "allow"
[workspace.dependencies]
alloy = { git = "https://github.com/alloy-rs/alloy", rev = "27d5ba9", features = [
"contract",
"consensus",
"eips",
"network",
"node-bindings",
"providers",
Expand Down
37 changes: 37 additions & 0 deletions examples/transactions/examples/encode_decode.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
use alloy::{
consensus::{SignableTransaction, TxEip1559},
eips::eip2930::AccessList,
primitives::{address, b256, hex, Signature, TxKind, U256},
};
use eyre::Result;
#[tokio::main]
async fn main() -> Result<()> {
// EIP1559 transaction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something cool would be to link to where the test vector was taken from (e.g etherscan link), that way ppl can also reproduce themselves

let signer = address!("DD6B8b3dC6B7AD97db52F08a275FF4483e024CEa");
let hash = b256!("0ec0b6a2df4d87424e5f6ad2a654e27aaeb7dac20ae9e8385cc09087ad532ee0");
let tx = TxEip1559 {
chain_id: 1,
nonce: 0x42,
gas_limit: 44386,
to: TxKind::Call( address!("6069a6c32cf691f5982febae4faf8a6f3ab2f0f6")),
value: U256::from(0_u64),
input: hex!("a22cb4650000000000000000000000005eee75727d804a2b13038928d36f8b188945a57a0000000000000000000000000000000000000000000000000000000000000000").into(),
max_fee_per_gas: 0x4a817c800,
max_priority_fee_per_gas: 0x3b9aca00,
access_list: AccessList::default(),
};

let sig = Signature::from_scalars_and_parity(
b256!("840cfc572845f5786e702984c2a582528cad4b49b2a10b9db1be7fca90058565"),
b256!("25e7109ceb98168d95b09b18bbf6b685130e0562f233877d492b94eee0c5b6d1"),
false,
)
.unwrap();

let signed_tx = tx.into_signed(sig);

// Match hash
assert_eq!(*signed_tx.hash(), hash);
// TODO: Recover Signer - Enable feature k256 on consensus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything blocking here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. As recover_signer is gated behind the k256, we're facing a similar issue to #26. Either need to make it default in alloy or fix the gating. cc @zerosnacks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha understood—are we tracking this issue somewhere? else i'll make it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we're tracking. Could reopen #26, I believe we'll encounter this few more times as more examples are written.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopened #26

Ok(())
}
Loading