feat(sol-types): rm validate: bool
#863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst and
mattsse
as code owners
DaniPopes
reviewed
Feb 3, 2025
| @@ -61,8 +61,8 @@ impl DynSolCall { | |||
| } | |||
|
|
|||
| /// ABI decode the given data as function returns. | |||
| pub fn abi_decode_input(&self, data: &[u8], validate: bool) -> Result<Vec<DynSolValue>> { | |||
| abi_decode(data, &self.parameters, validate) | |||
| pub fn abi_decode_input(&self, data: &[u8], _validate: bool) -> Result<Vec<DynSolValue>> { | |||
| ); | ||
| } | ||
| // #[test] | ||
| // fn decode_solidity_no_interface() { |
There was a problem hiding this comment.
as you can see here not all the validations are correct as we're rejecting valid inputs; this needs a bit more investigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, in
abi_decode_*methods of sol type traits (SolEnum,SolType,SolValue,SolCall,SolInterface,SolEvents), we expose avalidate: boolarg to bypass type-checking while decoding. We should always resort to type-checking.This type-checking ensures that bytes conform to expected type limitations and that the decoded values can be re-encoded to an identical byte-string.
Solution
validate: boolfromabi_decode_*fns of various sol type traits.sol!expansions.PR Checklist