Store all strings in a cache #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlgsmith
reviewed
Nov 28, 2024
blairsteven
force-pushed
the
string_cache
branch
from
48132b7 to
f5931be
Compare
Apteryxd can end up storing a lot of duplicated strings. This commit adds a cache to remove this duplication - it is called the same way strdup / free would be and will take care of allocating, reference counting and releasing strings. This cache has no locking, so needs to be called under an external lock. At the moment this used solely in code inside the db_lock in database.c
blairsteven
force-pushed
the
string_cache
branch
from
f5931be to
7c470f6
Compare
carlgsmith
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save on memory allocations by storing all keys and values in a hashtable and reusing them.
Saves ~15-20% RSS in some real world test cases.