Return DB timestamp for refreshed paths #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we alway returned "now" if there was a chance of a path being refreshed. That was because refreshed paths always had their timestamps updated to "now" even if the refresher decided not to update anything so that we did not call the refresher again for stale child nodes. Now that we do not use the DB timestamps to decide whether to call the refreshers anymore we can fix this odd behaviour. The change in behaviour is; 1. A call to a refresher does not result in all children of the path having their timestamps set to "now" even if they were not modified. 2. A call to get a timestamp for a path will call refreshers to make sure the timestamp is up to date.
blairsteven
approved these changes
Oct 8, 2024
sparlane
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we alway returned "now" if there was a chance of a path being refreshed. That was because refreshed paths always had their timestamps updated to "now" even if the refresher decided not to update anything so that we did not call the refresher again for stale child nodes. Now that we do not use the DB timestamps to decide whether to call the refreshers anymore we can fix this odd behaviour.
The change in behaviour is;