Fix an issue stopping netconf from shutting down cleanly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a netconf rpc is active when the server is shut down, then depending on timing, a crash can occur. The crash is due to the sessions and g_schema being deleted before an active thread in the thread pool is completed. An issue with the routine free_open_sessions has also been fixed.
Main improvement is to verify that the capability for :base:1.1 is present. If not found, we will end the session.
To support "with-defaults" in Netconf the handle_get function was updated to be much closer to the way restconf works. Tests were added validate the new "with-defaults" functionality based on Appendix A RFC6243.
The new exception shutdown strategy is to shut down the accept socket, then close any open session sockets. As the worker threads handling the open sessions close down they cleanup any remaining memory used by the session. Hence on process termination, an additional explicit cleanup routine for open sessions is not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new exception shutdown strategy is to shut down the accept socket,
then close any open session sockets. As the worker threads handling the
open sessions close down they cleanup any remaining memory used by
the session. Hence on process termination, an additional explicit
cleanup routine for open sessions is not required.