Fix for #976 to Ignore Unused Stock Variables #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change treats stock variables the same as public during when checking for unused variables.
|
This error is intentional. The warning should only elide on includes. |
|
Yup, okay. I will go to take a look tomorrow for whether the messages were present from includes. Then, take another look at a code fix. |
|
Yes, there are messages from inclusions. #976 |
This changes to also check swhether the VarDecl is from the main source file or not. Checking this seems easy enough with the new source file tracking. If a variable is from the main source file even if it is marked with stock we shall now report a warning. We could also ignore any unused variable that is not from the main file. But I shall stick with only stock for now. Testing Extended out the test to cover both the pass and fail cases.
|
Updated to elide the warning on includes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
This change looks to ignore stock variables that are not from the main source file.
Testing
Added two new compile tests for stock variables and arrays.