Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for themes with theme.json #7

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

emilyatmobtown
Copy link
Contributor

Summary

In order to support migration to/from themes with theme.json, we must check for migratability before wp_theme_has_theme_json() is run the first time. That happens through the wp_enable_block_templates callback on the setup_theme hook with a priority of 10 so this PR moves the migratability check to a priority of 8.

That also means all post types and taxonomies must be registered before that to be available for migratability checks.

Notes for reviewers

None.

Changelog entries

  • Added: Added support for themes with theme.json.
  • Changed: Changed the priority for the run() callback to 8.

Issue(s)

None.

Copy link
Contributor

@renatonascalves renatonascalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@emilyatmobtown emilyatmobtown merged commit c1bc1d3 into develop Jul 10, 2023
5 checks passed
@emilyatmobtown emilyatmobtown deleted the feature/support-theme-json branch July 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants