Issue-48: Change Newsletter Single Post to use inner blocks #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2023
attackant
approved these changes
Dec 1, 2023
| if ( empty( $wp_newsletter_builder_block_post ) || ! $wp_newsletter_builder_block_post ) { | ||
| return; | ||
| } | ||
| $wp_newsletter_builder_post_title = ! empty( $attributes['overrideTitle'] ) ? $attributes['overrideTitle'] : $wp_newsletter_builder_block_post->post_title; |
There was a problem hiding this comment.
This could be:
$wp_newsletter_builder_post_title = $attributes['overrideTitle'] ?? $wp_newsletter_builder_block_post->post_title;
src/class-block-modifications.php
Outdated
| if ( ! empty( $block['attrs']['overrideUrl'] ) ) { | ||
| add_filter( | ||
| 'post_link', | ||
| function() use ( $block ) { |
…hange-single-post-inner-blocks
…ost-inner-blocks' into feature/issue-48/change-single-post-inner-blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Change Newsletter Single Post to use inner blocks
about: Convert the display logic of Newsletter Single Post block to utilize inner blocks and context.
title: ''
labels: ''
assignees: ''
This PR switches the Newsletter Single Post block to use InnerBlocks and converts the Post Title and Post Featured Image to new blocks. We need to use custom blocks to allow for overrides. There will be more custom blocks in a future PR.
Issue Number
#48
Description
Currently, the logic for displaying a post is all inside the Newsletter Single Post block and powered by the show____ and order attributes. We should change this to use inner blocks and context. Hopefully the core inner blocks will work, but if not, we should create the necessary inner blocks. Display should still use the same markup, as that has been deemed "email safe".
Use Case
Using inner blocks will give editors more control over their templates and allow developers to create their own blocks to add to the layout to display an eyebrow, for instance.
Additional Context
This change will probably also allow us to use it in conjunction with the core Query Loop block or WP Curate query block, which will allow some sections of a newsletter to be more automated. See alleyinteractive/wp-newsletter-builder#26.