Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Single Send Templates #160

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Fix: Single Send Templates #160

merged 7 commits into from
Jun 26, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented Jun 26, 2024 •
edited
Loading

Summary

For single sends, a chosen template needs to have at least one Single Post Block in the content. This PR puts guards in place that:

  • do not allow the newsletter to be sent if the template doesn't include a single post block
  • creates messaging for the user if the template is invalid

Notes for reviewers

  • version bump after CR

Ticket(s)

https://l.alley.dev/75b5288d9c

@efuller efuller marked this pull request as ready for review June 26, 2024 15:53
cahdeemer
cahdeemer approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@cahdeemer cahdeemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@efuller efuller merged commit 916d98b into develop Jun 26, 2024
6 checks passed
@efuller efuller deleted the fix/single-send-templates branch June 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahdeemer cahdeemer cahdeemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efuller @cahdeemer