Fixes permalink logic in post-featured-image, post-read-more, and…

… `post-title` blocks
alleyinteractive · Apr 1, 2024 · d84f3eb · d84f3eb
1 parent f7065a0
commit d84f3eb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/blocks/post-featured-image/render.php b/blocks/post-featured-image/render.php
@@ -18,8 +18,8 @@
 $wp_newsletter_builder_img_sizes  = $attributes['imgSizes'] ?? '';
 $wp_newsletter_builder_post_image = ! empty( $attributes['overrideImage'] ) ? $attributes['overrideImage'] : get_post_thumbnail_id( $wp_newsletter_builder_block_post->ID );
 
-$wp_newsletter_builder_post_permalink = get_the_permalink();
+$wp_newsletter_builder_post_permalink = (string) get_the_permalink();
 ?>
-<a <?php echo wp_kses_data( get_block_wrapper_attributes( [ 'class' => 'post__image-link' ] ) ); ?> href="<?php echo esc_url( ! empty( $wp_newsletter_builder_post_permalink ) ? $wp_newsletter_builder_post_permalink : '' ); ?>">
+<a <?php echo wp_kses_data( get_block_wrapper_attributes( [ 'class' => 'post__image-link' ] ) ); ?> href="<?php echo esc_url( $wp_newsletter_builder_post_permalink ); ?>">
 	<?php echo wp_get_attachment_image( $wp_newsletter_builder_post_image, 'full', false, [ 'sizes' => $wp_newsletter_builder_img_sizes ] ); ?>
 </a>
diff --git a/blocks/post-read-more/render.php b/blocks/post-read-more/render.php
@@ -17,15 +17,15 @@
 }
 $wp_newsletter_builder_read_more_text = $attributes['readMoreText'] ?? __( 'Read More', 'wp-newsletter-builder' );
 
-$wp_newsletter_builder_post_url = get_the_permalink();
+$wp_newsletter_builder_post_permalink = (string) get_the_permalink();
 ?>
 <div <?php echo wp_kses_data( get_block_wrapper_attributes( [ 'class' => 'wp-block-button has-text-align-center' ] ) ); ?>>
 	<!--[if mso]>
-	<v:roundrect xmlns:v="urn:schemas-microsoft-com:vml" xmlns:w="urn:schemas-microsoft-com:office:word" href="<?php echo esc_url( ! empty( $wp_newsletter_builder_post_permalink ) ? $wp_newsletter_builder_post_permalink : '' ); ?>" style="height:48px;v-text-anchor:middle;width:200px;" arcsize="10%" stroke="f" fillcolor="#D62827">
+	<v:roundrect xmlns:v="urn:schemas-microsoft-com:vml" xmlns:w="urn:schemas-microsoft-com:office:word" href="<?php echo esc_url( $wp_newsletter_builder_post_permalink ); ?>" style="height:48px;v-text-anchor:middle;width:200px;" arcsize="10%" stroke="f" fillcolor="#D62827">
 		<w:anchorlock/>
 		<center>
 	<![endif]-->
-	<a class="wp-element-button" href="<?php echo esc_url( ! empty( $wp_newsletter_builder_post_permalink ) ? $wp_newsletter_builder_post_permalink : '' ); ?>">
+	<a class="wp-element-button" href="<?php echo esc_url( $wp_newsletter_builder_post_permalink ); ?>">
 		<?php echo esc_html( $wp_newsletter_builder_read_more_text ); ?>
 	</a>
 	<!--[if mso]>

diff --git a/blocks/post-title/render.php b/blocks/post-title/render.php
@@ -20,9 +20,9 @@
 $wp_newsletter_builder_smaller_font = $attributes['smallerFont'] ?? false;
 $wp_newsletter_builder_title_class  = $wp_newsletter_builder_smaller_font ? 'post__title--small' : '';
 
-$wp_newsletter_builder_post_permalink = get_the_permalink();
+$wp_newsletter_builder_post_permalink = (string) get_the_permalink();
 ?>
-<a <?php echo wp_kses_data( get_block_wrapper_attributes( [ 'class' => 'post__title-link' ] ) ); ?> href="<?php echo esc_url( ! empty( $wp_newsletter_builder_post_permalink ) ? $wp_newsletter_builder_post_permalink : '' ); ?>">
+<a <?php echo wp_kses_data( get_block_wrapper_attributes( [ 'class' => 'post__title-link poop' ] ) ); ?> href="<?php echo esc_url( $wp_newsletter_builder_post_permalink ); ?>">
 	<h2 class="<?php echo esc_attr( $wp_newsletter_builder_title_class ); ?>">
 		<?php if ( ! empty( $wp_newsletter_builder_number ) ) : ?>
 			<span class="newsletter-post__number"><?php echo esc_html( $wp_newsletter_builder_number ); ?>.</span>