code review feedback

alleyinteractive · Dec 4, 2023 · 76c15da · 76c15da
1 parent 450a8bc
commit 76c15da
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 32 deletions.
diff --git a/blocks/post-content/block.json b/blocks/post-content/block.json
@@ -6,10 +6,9 @@
 	"title": "Newsletter Post Content",
 	"category": "design",
 	"icon": "admin-post",
-	"description": "Displays a post content",
+	"description": "Displays the contents of a post.",
 	"textdomain": "wp-newsletter-builder",
 	"editorScript": "file:index.ts",
-	"editorStyle": "file:index.css",
 	"style": [
 		"file:style-index.css"
 	],

diff --git a/blocks/post-content/edit.tsx b/blocks/post-content/edit.tsx
@@ -4,8 +4,6 @@ import { __ } from '@wordpress/i18n';
 import { RichText, useBlockProps } from '@wordpress/block-editor';
 import { WP_REST_API_Post } from 'wp-types';
 
-import './index.scss';
-
 interface EditProps {
   attributes: {
     overrideContent?: string;
@@ -33,7 +31,7 @@ export default function Edit({
   },
   setAttributes,
 }: EditProps) {
-  // @ts-ignore
+  // @ts-ignore - WP_REST_API_Post is not in CamelCase.
   const record: WP_REST_API_Post = usePostById(postId) ?? null;
 
   let postContent = record ? record.content.rendered : __('<p>This block will display the content.</p>', 'wp-newsletter-builder');

diff --git a/blocks/post-content/index.scss b/blocks/post-content/index.scss
diff --git a/blocks/post-content/index.ts b/blocks/post-content/index.ts
@@ -29,8 +29,6 @@ registerBlockType(
   /* @ts-expect-error Provided types are inaccurate to the actual plugin API. */
   metadata,
   {
-    apiVersion: 2,
     edit,
-    title: metadata.title,
   },
 );
diff --git a/blocks/post-read-more/block.json b/blocks/post-read-more/block.json
@@ -9,7 +9,6 @@
 	"description": "Displays a post read more button",
 	"textdomain": "wp-newsletter-builder",
 	"editorScript": "file:index.ts",
-	"editorStyle": "file:index.css",
 	"style": [
 		"file:style-index.css"
 	],

diff --git a/blocks/post-read-more/edit.tsx b/blocks/post-read-more/edit.tsx
@@ -2,8 +2,6 @@
 import { __ } from '@wordpress/i18n';
 import { RichText, useBlockProps } from '@wordpress/block-editor';
 
-import './index.scss';
-
 interface EditProps {
   attributes: {
     readMoreText?: string;
@@ -28,8 +26,6 @@ export default function Edit({
   },
   setAttributes,
 }: EditProps) {
-  // @ts-ignore
-
   const buttonText = readMoreText || __('Read More', 'wp-newsletter-builder');
 
   return (

diff --git a/blocks/post-read-more/index.scss b/blocks/post-read-more/index.scss
diff --git a/blocks/post-read-more/index.ts b/blocks/post-read-more/index.ts
@@ -29,8 +29,6 @@ registerBlockType(
   /* @ts-expect-error Provided types are inaccurate to the actual plugin API. */
   metadata,
   {
-    apiVersion: 2,
     edit,
-    title: metadata.title,
   },
 );