Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH-111: CI/CD and Linting Updates #99

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented Jun 6, 2024

Summary

The goal here was to help refine GH actions as well as achieve fewer PHPCS and PHPStan errors out of the box when scaffolding a new project. There's no doubt there will be more fixes needed.

PR Details

  • Sets Node versions to 20
  • Sets PHP versions to 8.2
  • Improves PHPStan compliance out of the box
  • Improves PHPCS compliance out of the box

Notes

Ticket

https://l.alley.dev/08d4bfa65c

@efuller efuller requested a review from a team as a code owner June 6, 2024 13:16
Copy link
Member

@goodguyry goodguyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@efuller efuller merged commit 71f8fd4 into develop Jun 12, 2024
@efuller efuller deleted the feature/tech-111/github-action-updates branch June 12, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants