Add support for Windows filepaths

alleyinteractive · Dec 18, 2023 · c470aad · c470aad
1 parent 35e6eb0
commit c470aad
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/byline-manager.php b/byline-manager.php
@@ -24,6 +24,17 @@
 
 define( 'BYLINE_MANAGER_PATH', __DIR__ . '/' );
 
+/**
+ * Helper function to validate a path before doing something with it.
+ *
+ * @param string $path The path to validate.
+ *
+ * @return bool True if the path is valid, false otherwise.
+ */
+function validate_path( string $path ) : bool {
+	return in_array( validate_file( $path ), [ 0, 2 ], true ) && file_exists( $path );
+}
+
 // Autoloader.
 require_once BYLINE_MANAGER_PATH . 'inc/autoload.php';
 

diff --git a/inc/assets.php b/inc/assets.php
@@ -160,7 +160,7 @@ function get_asset_dependencies( string $asset ) : array {
 	}
 
 	// Ensure the filepath is valid.
-	if ( ! file_exists( $dependency_file ) || 0 !== validate_file( $dependency_file ) ) {
+	if ( validate_path( $dependency_file ) ) {
 		return [];
 	}
 
@@ -223,7 +223,7 @@ function get_asset_property( string $asset, string $prop ) : ?string {
  * @return array The asset map.
  */
 function read_asset_map( string $path ) : array {
-	if ( file_exists( $path ) && 0 === validate_file( $path ) ) {
+	if ( validate_path( $path ) ) {
 		ob_start();
 		include $path; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.IncludingFile, WordPressVIPMinimum.Files.IncludingFile.UsingVariable
 		return json_decode( ob_get_clean(), true );