Allow phpstan to run, address commentary

composer.json

@@ -16,13 +16,15 @@
         "phpstan/phpstan": "^1.10",
         "szepeviktor/phpstan-wordpress": "^1.1.6",
         "yoast/phpunit-polyfills": "^2.0",
-        "axepress/wp-graphql-stubs": "^1.14"
+        "axepress/wp-graphql-stubs": "^1.14",
+        "yoast/wordpress-seo": "^22.7"
     },
     "config": {
         "allow-plugins": {
             "dealerdirect/phpcodesniffer-composer-installer": true,
             "alleyinteractive/composer-wordpress-autoloader": true,
-            "phpstan/extension-installer": true
+            "phpstan/extension-installer": true,
+            "composer/installers": false
         }
     },
     "scripts": {
@@ -37,5 +39,10 @@
             "@phpstan",
             "@phpunit"
         ]
+    },
+    "extra": {
+        "installer-paths": {
+            "vendor/{$vendor}/{$name}/": ["type:wordpress-plugin"]
+        }
     }
 }

inc/models/class-profile.php

@@ -19,10 +19,11 @@
  *
  * Dynamic properties.
  *
- * @property int    $post_id Post ID for the profile.
- * @property int    $term_id Term ID for the profile.
+ * @property int    $post_id      Post ID for the profile.
+ * @property int    $term_id      Term ID for the profile.
  * @property string $display_name Display name for the profile.
- * @property string $user_url User url.
+ * @property string $user_url     User url.
+ * @property string $link         Profile permalink.
  */
 class Profile {
 	/**

inc/yoast.php

@@ -31,8 +31,8 @@
  * @return string Filtered tag.
  */
 function filter_wpseo_meta_author( $author_name, $presentation ): string {
-	$id   = $presentation?->context?->post?->ID;
-	$type = $presentation?->model?->object_sub_type;
+	$id   = $presentation->context->post->ID;
+	$type = $presentation->model->object_sub_type;
 
 	if ( $id && $type && Utils::is_post_type_supported( $type ) ) {
 		$author_name = get_the_byline( $id );
@@ -49,8 +49,8 @@ function filter_wpseo_meta_author( $author_name, $presentation ): string {
  * @return array Filtered data.
  */
 function filter_wpseo_enhanced_slack_data( $data, $presentation ): array {
-	$id   = $presentation?->context?->post?->ID;
-	$type = $presentation?->model?->object_sub_type;
+	$id   = $presentation->context->post->ID;
+	$type = $presentation->model->object_sub_type;
 
 	if ( $id && $type && Utils::is_post_type_supported( $type ) ) {
 		$byline = get_the_byline( $id );
@@ -74,8 +74,8 @@ function filter_wpseo_enhanced_slack_data( $data, $presentation ): array {
  */
 function filter_wpseo_schema_graph_pieces( $schema_pieces, $context ) {
 	if (
-		'post' === $context?->indexable?->object_type
-		&& Utils::is_post_type_supported( $context?->indexable?->object_sub_type )
+		'post' === $context->indexable->object_type
+		&& Utils::is_post_type_supported( $context->indexable->object_sub_type )
 	) {
 		$schema_pieces = array_filter( $schema_pieces, fn ( $piece ) => ! $piece instanceof Person );
 	}
@@ -107,8 +107,8 @@ function filter_wpseo_schema_graph( $graph, $context ) {
 	 * It's easier to create the schema pieces and generate their output here, rather than filtering the schema
 	 * pieces into 'filter_schema_graph_pieces', because Yoast allows only one node of each '@type' in the graph.
 	 */
-	if ( 'post' === $context?->indexable?->object_type && Utils::is_post_type_supported( $context?->indexable?->object_sub_type ) ) {
-		foreach ( Utils::get_byline_entries_for_post( $context?->indexable?->object_id ) as $entry ) {
+	if ( 'post' === $context->indexable->object_type && Utils::is_post_type_supported( $context->indexable->object_sub_type ) ) {
+		foreach ( Utils::get_byline_entries_for_post( $context->indexable->object_id ) as $entry ) {
 			if ( $entry instanceof Profile ) {
 				$schema_pieces[] = new Profile_Schema( $entry, $helpers, $context );
 			}