Merge pull request #261 from alleyinteractive/hotfix/createroot-error

Fix incorrect usage of ReactDOM.createRoot()
alleyinteractive · Feb 14, 2024 · 14d46d8 · 14d46d8
2 parents 17d0c73 + adc64a9
commit 14d46d8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/client/src/init-byline-metabox.js b/client/src/init-byline-metabox.js
@@ -6,10 +6,8 @@ import BylineMetaBox from 'components/byline-metabox';
 const initBylineMetaBox = () => {
   const { bylineMetaBox } = bylineData;
 
-  ReactDOM.createRoot(
-    <BylineMetaBox bylineMetaBox={bylineMetaBox} />,
-    document.getElementById('byline-manager-metabox-root'),
-  );
+  ReactDOM.createRoot(document.getElementById('byline-manager-metabox-root'))
+    .render(<BylineMetaBox bylineMetaBox={bylineMetaBox} />);
 };
 
 export default initBylineMetaBox;
diff --git a/client/src/init-user-link-metabox.js b/client/src/init-user-link-metabox.js
@@ -17,17 +17,18 @@ const initUserLinkMetaBox = () => {
     usersApiUrl,
   } = bylineData;
 
-  ReactDOM.createRoot(
-    <UserLinkMetaBox
-      linkUserPlaceholder={linkUserPlaceholder}
-      linkedToLabel={linkedToLabel}
-      postId={+postId}
-      unlinkLabel={unlinkLabel}
-      user={user}
-      userAlreadyLinked={userAlreadyLinked}
-      usersApiUrl={usersApiUrl}
-    />,
-    userLinkEl,
+  ReactDOM.createRoot(userLinkEl).render(
+    (
+      <UserLinkMetaBox
+        linkUserPlaceholder={linkUserPlaceholder}
+        linkedToLabel={linkedToLabel}
+        postId={+postId}
+        unlinkLabel={unlinkLabel}
+        user={user}
+        userAlreadyLinked={userAlreadyLinked}
+        usersApiUrl={usersApiUrl}
+      />
+    ),
   );
 };