Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove import search within current directory #611

Closed
wants to merge 4 commits into from
Closed

Remove import search within current directory #611

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbb55a3
fix #606 with a .ignore file required
wrencanfly Nov 2, 2023
5f83517
update 11/15
wrencanfly Nov 16, 2023
ee46282
undo .ignore file and :: import
apoorvkh Nov 24, 2023
b445ab0
Merge branch 'main' into fix-import-search
dirkgr May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions tango/common/registrable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,31 +213,6 @@ def try_import(module, recursive: bool = True):
if name in Registrable._registry[cls]:
return None

# Check Python files and modules in the current directory.
from glob import glob
from pathlib import Path

for pyfile in glob("*.py"):
module = str(Path(pyfile).with_suffix(""))
if module == "setup":
continue
try:
try_import(module)
if name in Registrable._registry[cls]:
return None
except: # noqa: E722
continue
for pyinit in glob("**/__init__.py"):
module = str(Path(pyinit).parent)
if module == "tango" or module.startswith("test"):
continue
try:
try_import(module)
if name in Registrable._registry[cls]:
return None
except: # noqa: E722
continue

# Search all other modules in Tango.
for module in find_submodules(exclude={"tango.integrations*"}, recursive=False):
try_import(module)
Expand Down
Loading