Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support weka evaluation oe eval #435

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

vwxyzjn
Copy link
Collaborator

@vwxyzjn vwxyzjn commented Nov 13, 2024

Tested with the following.

# weka eval
python scripts/submit_eval_jobs.py \
    --model_name ppo_ray_3.9_1111_β_0.1_epoch_1__weka_eval \
    --location /weka/oe-adapt-default/costah/models/rlvr/1111/ppo_ray_3.9_1111_β_0.1_epoch_{1} \
    --cluster ai2/saturn-cirrascale ai2/neptune-cirrascale ai2/jupiter-cirrascale-2	 --evaluate_on_weka \
    --is_tuned \
    --workspace "tulu-3-results" \
    --priority high \
    --preemptible \
    --use_hf_tokenizer_template \
    --beaker_image "nathanl/open_instruct_auto" \
    --upload_to_hf allenai/tulu-3-evals \
    --run_oe_eval_experiments \
    --run_safety_evaluations \
    --skip_oi_evals

# nfs eval
python scripts/submit_eval_jobs.py \
    --model_name ppo_ray_3.9_1111_β_0.1_epoch_1__nfs_eval \
    --location 01JCE2PYZW1E96994GMW7MDB4R \
    --is_tuned \
    --workspace "tulu-3-results" \
    --priority high \
    --preemptible \
    --use_hf_tokenizer_template \
    --beaker_image "nathanl/open_instruct_auto" \
    --upload_to_hf allenai/tulu-3-evals \
    --run_oe_eval_experiments \
    --run_safety_evaluations \
    --skip_oi_evals

Note the only difference is that

    --location /weka/oe-adapt-default/costah/models/rlvr/1111/ppo_ray_3.9_1111_β_0.1_epoch_{1} \
    --cluster ai2/saturn-cirrascale ai2/neptune-cirrascale ai2/jupiter-cirrascale-2	 --evaluate_on_weka \

vs

    --location 01JCE2PYZW1E96994GMW7MDB4R \

@vwxyzjn
Copy link
Collaborator Author

vwxyzjn commented Nov 13, 2024

Seems to work both for beaker dataset and weka

image image

Copy link
Contributor

@jacob-morrison jacob-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@natolambert natolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thx

@natolambert natolambert merged commit fe2817d into main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants