Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experiment name #391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove experiment name #391

wants to merge 1 commit into from

Conversation

vwxyzjn
Copy link
Collaborator

@vwxyzjn vwxyzjn commented Oct 16, 2024

This PR removes the --experiment_name in favor of grabbing info from --exp_name. It's a bit less organized but I think it's fine because we should not rely on beaker search to find experiments. We should be using the tracked experiments from wandb to find the beaker experiment ID.

Copy link
Collaborator

@natolambert natolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. model_name no longer used? I see deletion of it without adding it back in. Maybe the deleted code was just changing the name, not init the var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants