-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge boxes from citation mention model #273
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
09f42f6
merge boxes from citation mention model
gituser768 8bb41a5
Update interface.py
gituser768 9175b30
major version bump
gituser768 951ab36
Update pyproject.toml
gituser768 a726090
pull boxgroup from span.box
gituser768 ae037c2
remove unneeded boxes on spans
gituser768 dcbfdd0
cleanup like angele said
gituser768 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[project] | ||
name = 'mmda' | ||
version = '0.9.9' | ||
version = '0.9.10' | ||
description = 'MMDA - multimodal document analysis' | ||
authors = [ | ||
{name = 'Allen Institute for Artificial Intelligence', email = '[email protected]'}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you seeing that the line grouping is working well? I think it could be better if we had
rows
passed into this model, so that we can take advantage of pdfplumber's grouping by lines which I think is more robust than requiring exactt
coordinates matching up (seemmda/src/mmda/parsers/pdfplumber_parser.py
Line 370 in 5c2fb76
mmda/src/mmda/predictors/heuristic_predictors/figure_table_predictors.py
Line 53 in 6ab9004
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it actually seems to work well! if the lines dont have the same
t
then I think it's safest to just not do anything.