[pr] Okta Challenge Preferences #93
Conversation
As I had issues with Clisso not selecting push notifications but require me to enter codes instead of using push, even though I only had okta push turned on, I added this functionality, so we prefer push when possible but make it configurable for whoever is into doing it. Worked well here so far in different scenarios.
ghost
changed the title
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@sandrom you can click here to see the review status or cancel the code review job.
| } `json:"_embedded"` | ||
| } | ||
|
|
||
| type factor struct { |
| @@ -43,6 +44,7 @@ func init() { | |||
|
|
|||
| // Okta | |||
| cmdProvidersCreateOkta.Flags().StringVar(&baseURL, "base-url", "", "Okta base URL") | |||
| cmdProvidersCreateOkta.Flags().StringArrayVar(&challenges, "challenges", []string{"push", "token:software:totp"}, "Challenges to be used with preference") | |||
| @@ -23,6 +23,7 @@ var providerDuration int | |||
|
|
|||
| // Okta | |||
| @@ -163,3 +173,34 @@ func Get(app, provider string, duration int64) (*aws.Credentials, error) { | |||
|
|
|||
| return creds, err | |||
| } | |||
|
|
|||
| func typeMapOf(factors []factor) (m map[string]factor) { | |||
There was a problem hiding this comment.
This code all looks good, but I don't see any accompanying unit tests. I strongly recommend adding these to protect the code against future changes that could unintentionally break things; and it may also be a good clean place to start with that if you haven't already as there aren't many dependencies.
There was a problem hiding this comment.
Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard
There was a problem hiding this comment.
This pull request should be reviewed by PullRequest because the title contains "[pr]"; however since review has been cancelled, it can only be re-sent manually from the PullRequest dashboard.
|
|
As I had issues with Clisso not selecting push notifications but require me to enter codes instead of using push, even though I only had okta push turned on, I added this functionality, so we prefer push when possible but make it configurable for whoever is into doing it. Worked well here so far in different scenarios.