Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance credential process and logging #426

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

bitte-ein-bit
Copy link
Member

@bitte-ein-bit bitte-ein-bit commented Jul 11, 2024

Enhance the credential_process:

  • implement a way to disable temporarily
  • auto-configure profiles to use Clisso for temporary credentials

Rewrite logging, add more tests to ease maintainability

@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 9893865729

Details

  • 160 of 388 (41.24%) changed or added relevant lines in 18 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+4.8%) to 34.676%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spinner/spinner_unix.go 0 1 0.0%
cmd/root.go 0 2 0.0%
keychain/keychain.go 1 3 33.33%
cmd/helpers.go 32 37 86.49%
cmd/status.go 0 6 0.0%
saml/saml.go 8 15 53.33%
aws/sts.go 0 8 0.0%
okta/get.go 0 8 0.0%
aws/aws.go 37 49 75.51%
onelogin/get.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/get.go 2 20.64%
log/log.go 10 31.69%
Totals Coverage Status
Change from base Build 9853194767: 4.8%
Covered Lines: 680
Relevant Lines: 1961

💛 - Coveralls

@bitte-ein-bit bitte-ein-bit changed the title advanced credential process enhance credential process and logging Jul 11, 2024
@bitte-ein-bit bitte-ein-bit merged commit 77eb63e into master Jul 11, 2024
13 checks passed
@bitte-ein-bit bitte-ein-bit deleted the feature/lock-credential-process branch July 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants