Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[risk=low][RW-11368] Bump browser-tools to retrieve more modern Chromedrivers #8244

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[risk=low][RW-11368] Bump browser-tools to retrieve more modern Chromedrivers #8244

merged 1 commit into from
Dec 20, 2023

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Dec 20, 2023 •
edited
Loading

As a result of the Circle image update in #8238, we now test against a more recent version of Chrome. However, the APIs for retrieving a Chromedriver have changed since then: CircleCI-Public/browser-tools-orb#75

Update our browser-tools orb to a version with the fix (1.4.2+) https://github.com/CircleCI-Public/browser-tools-orb/releases/tag/v1.4.2

PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@jmthibault79 jmthibault79 marked this pull request as ready for review December 20, 2023 16:38
@jmthibault79 jmthibault79 requested review from a team and chenchals and removed request for a team December 20, 2023 16:38
chenchals
chenchals reviewed Dec 20, 2023
View reviewed changes
ui/src/app/pages/workspace/workspace-about.tsx Outdated
@@ -360,6 +360,7 @@ export const WorkspaceAbout = fp.flow(
>
Unpublish
</Button>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need a new line.

chenchals
chenchals approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@chenchals chenchals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmthibault79 jmthibault79 merged commit d41f481 into main Dec 20, 2023
6 of 12 checks passed
@jmthibault79 jmthibault79 deleted the joel/fix-j17-circle branch December 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenchals chenchals chenchals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmthibault79 @chenchals