Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warnings as errors until we move to GCC 13 #5596

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ktf
Copy link
Member

@ktf ktf commented Aug 29, 2024

Disable warnings as errors until we move to GCC 13

-Wno-error=dangling-reference is available only there.

-Wno-error=dangling-reference is available only there.
@ktf ktf requested a review from a team as a code owner August 29, 2024 07:10
@ktf ktf merged commit 8773f03 into alisw:master Aug 29, 2024
3 checks passed
@ktf
Copy link
Member Author

ktf commented Aug 29, 2024

As expected, enabling the warnings as errors breaks as soon as we move to a new compiler. Disabling for now until we merged GCC 13.

@ktf ktf deleted the pr5596 branch August 29, 2024 07:12
@davidrohr
Copy link
Contributor

davidrohr commented Aug 29, 2024 via email

@ktf
Copy link
Member Author

ktf commented Aug 29, 2024

The issue is that the warning is new, so passing -Wno-error=dangling-reference only works if we are at GCC 13. I prefer not to pollute code in with pragma diagnostic, if a temporary solution in alidist brings us where we want.

@vkucera
Copy link
Contributor

vkucera commented Oct 9, 2024

@ktf @ddobrigk

  • Was this communicated to the community (WP14+WP4 meeting, email, Mattermost)? I don't see any announcement about this.
  • Why was it not reverted immediately after merging Migrate to GCC 13 #5541 ?
  • Why has it not been reverted yet? (more than a month after fixing the reason for merging it!)
  • After enabling the warnings as errors now, many PRs in O2Physics will fail because of unrelated warnings accumulated over the last month and people will have to fix them even though they didn't introduce them. How can we avoid this in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants