Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset CFLAGS on python recipe #5594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Don't reset CFLAGS on python recipe #5594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ esac
if [[ $OPENSSL_ROOT ]]; then
export CPATH="$OPENSSL_ROOT/include:$OPENSSL_ROOT/include/openssl:$CPATH"
export CPPFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl $CPPFLAGS"
export CFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe what we should do is really drop CFLAFS, since most likely CPPFLAGS is enough. Could you check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compilation without CFLAGS ends successfully, but I get a crash on env activation with this error:

alienv enter Python/latest-ubuntu2204_x86-64-o2
Loading Python/latest-ubuntu2204_x86-64-o2
  Module ERROR: /home/admin/test_openssl_py/sw/ubuntu2204_x86-64/Python/v3.9.16-local1/bin/python3: error while loading shared libraries: libcrypt.so.2: cannot open shared object file: No such file or directory
        while executing
    "exec $PKG_ROOT/bin/python3 -c "import certifi; print(certifi.where())""
        (file "/home/admin/test_openssl_py/sw/MODULES/ubuntu2204_x86-64/Python/latest-ubuntu2204_x86-64-o2" line 26)
    Please contact <root@localhost>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then it's needed...

export CFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl $CFLAGS"
cat >> Modules/Setup.dist <<EOF

SSL=$OPENSSL_ROOT
Expand Down
Loading