Improve error reporting in aliBuild clean #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TimoWilken
commented
Nov 25, 2023
TimoWilken
commented
- Report the actual error when cleanup fails.
- Keep going when one directory can't be deleted. This should stop one failing dir from completely blocking all cleanup in CI.
- Use logging to show messages, to match the rest of aliBuild.
- Fix decideClean docstring to match its code.
- Adjust tests to match.
1. Report the actual error when cleanup fails. 2. Keep going when one directory can't be deleted. This should stop one failing dir from completely blocking all cleanup in CI. 3. Use logging to show messages, to match the rest of aliBuild. 4. Fix decideClean docstring to match its code. 5. Adjust tests to match.
TimoWilken
force-pushed
the
cleanup-better-logging
branch
from
0e9d07b
to
6d648ed
Compare
|
@ktf I've added tests to cover all the branches in doClean as well. Could you merge this as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.