Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rhel9 #808

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Add support for rhel9 #808

merged 4 commits into from
Oct 18, 2023

Conversation

Barthelemy
Copy link
Collaborator

No description provided.

@TimoWilken
Copy link
Contributor

Hi Barth, thank you, but in the past we've always used slcX for all distros compatible with RHEL version X, e.g. slc8 for CentOS 8, Alma 8, RHEL 8 etc. If there's nothing special about RHEL9, I'd keep doing the same and just call it slc9.

Good point about adding it to the help message and S3_SUPPORTED_ARCHS, we should do that for rhel9 or slc9, whatever it ends up being called.

@Barthelemy
Copy link
Collaborator Author

Hi,
I see, I am not against using slc9 if that is the convention.
I'll update the PR.

@Barthelemy
Copy link
Collaborator Author

is it what you meant ?

@TimoWilken
Copy link
Contributor

I would also remove the unused "rhel" pattern (done in 4ccd30c), but apart from that it looks perfect to me! I'll merge it once the checks are done.

Copy link
Contributor

@TimoWilken TimoWilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Barthelemy!

@awegrzyn
Copy link
Collaborator

awegrzyn commented Oct 18, 2023

Just FYI, currently distro package returns:

  • ('Red Hat Enterprise Linux', '9.2', 'Plow') for RHEL9
  • ('AlmaLinux', '9.2', 'Turquoise Kodkod') for Alma9

Therefore, with current implementation of doDetectArch we end up with: rhel9_x86-64 and slc9_x86-64 respectively.
To unify that I'd simply add red hat enterprise linux to https://github.com/alisw/alibuild/blob/master/alibuild_helpers/utilities.py#L153

@TimoWilken
Copy link
Contributor

Good catch, thanks @awegrzyn! I'll change it as you suggest.

@TimoWilken TimoWilken merged commit 148fd4b into alisw:master Oct 18, 2023
11 checks passed
@TimoWilken
Copy link
Contributor

Merged; thanks @Barthelemy and @awegrzyn! In case of any further issues, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants