Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve disable by architecture #760

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ktf
Copy link
Member

@ktf ktf commented May 13, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #760 (52b7718) into master (35bf9aa) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   87.17%   87.18%   +0.01%     
==========================================
  Files          29       29              
  Lines        2970     2982      +12     
==========================================
+ Hits         2589     2600      +11     
- Misses        381      382       +1     
Impacted Files Coverage Δ
alibuild_helpers/utilities.py 88.88% <62.50%> (-0.71%) ⬇️
tests/test_workarea.py 95.65% <0.00%> (-0.07%) ⬇️
tests/test_args.py 98.18% <0.00%> (ø)
tests/test_build.py 95.70% <0.00%> (ø)
alibuild_helpers/args.py 98.36% <0.00%> (+0.02%) ⬆️
alibuild_helpers/build.py 80.15% <0.00%> (+0.34%) ⬆️
alibuild_helpers/workarea.py 90.38% <0.00%> (+0.80%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ktf
Copy link
Member Author

ktf commented May 13, 2022

@davidrohr @martenole @awegrzyn: this should allow us to say that we do not want to bother about OpenSSL on anything but slc7. Either by stating:

architeture: slc7

which will simply disable the package on anything which is not slc7, or by saying:

system_requirement: slc7

which will consider the prefer_system_check (or alternatively system_requirement_check) as mandatory for the build to continue.

@awegrzyn could you please have a look? In principle this allows us to drop the system-XYZ packages as well, but IIRC you depend on those to create the RPMs. Is that actually the case?

@ktf
Copy link
Member Author

ktf commented May 13, 2022

@TimoWilken could you cross check this makes sense?

@davidrohr
Copy link
Contributor

@ktf : thx, I think this makes a lot of sense (haven't tested it myself though).

Copy link
Contributor

@TimoWilken TimoWilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful to me!

alibuild_helpers/utilities.py Outdated Show resolved Hide resolved
alibuild_helpers/utilities.py Show resolved Hide resolved
ktf and others added 3 commits August 29, 2024 11:56
This allows us to define that a given package can only be
built on certain architectures. This is done via the architecture
tag, e.g.:

architecture: slc7 # build on slc7 only
architecture: (?!osx) # Do not build on macOS
architecture: (slc7|slc6) # Only slc6 and slc7

This avoids having to specify in every dependent of the package
the conditional requirement string. It also has the advantage
that when a package is disabled, but still present on the
system because
This allows people to define system requirements also for
packages which have a recipe. It also falls back to prefer_system_check
when system_requirement_check is missing. This will allow us,
for example to say:

system_requirement: (ubuntu|osx)

for packages which want to pick up from the system on those two
architectures, e.g. openssl.
@singiamtel singiamtel force-pushed the improve-disable-by-architecture branch from 52b7718 to f43ac2e Compare August 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants