Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEG-137: Move recaching to queue consumer changes #6

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

anton-karunarathne-aligent
Copy link

@anton-karunarathne-aligent anton-karunarathne-aligent commented Jan 19, 2024

This PR content following changes.

  • Create new queue consumer for prerender recaching
  • Once the reindex process happened for prerender_product, prerender_category, prerender_category_product indexers execute recaching via queue consumer.
  • PHP 8.1 compatibility changes

@anton-karunarathne-aligent
Copy link
Author

anton-karunarathne-aligent commented Jan 21, 2024

@aligent-lturner I've updated the code with support php 8 , but looks like https://github.com/aligent/magento2-prerender/actions/runs/7578261074/job/20640572687?pr=6 coding standards check php 7.4 and failed.
Shall I readjust the code for PHP 7.4 ?

@aligent-lturner
Copy link
Collaborator

@anton-karunarathne-aligent you should be able to update the github action here (https://github.com/aligent/magento2-prerender/blob/1fb6078987616e8280db677dacbb2f33ad7e6723/.github/workflows/php.yml) to use the 8.1 version of the pipe

@aligent-lturner
Copy link
Collaborator

@anton-karunarathne-aligent you will also need to update composer.json to only support v8.1

@anton-karunarathne-aligent
Copy link
Author

@aligent-lturner after I've updated the git hub action on https://github.com/aligent/magento2-prerender/blob/1fb6078987616e8280db677dacbb2f33ad7e6723/.github/workflows/php.yml pipe as 8.1 , I'm getting following error. Any idea to solving the issue.

`fatal: detected dubious ownership in repository at '/github/workspace'
To add an exception for this directory, call:

git config --global --add safe.directory /github/workspace

Traceback (most recent call last):
File "/pipe.py", line 256, in
pipe.run()
File "/pipe.py", line 244, in run
self.run_code_standards_check()
File "/pipe.py", line 92, in run_code_standards_check
merge_base = subprocess.check_output(["git",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/subprocess.py", line 466, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'merge-base', 'HEAD', 'origin/main']' returned non-zero exit status 128.`

anton.karunarathne added 3 commits March 27, 2024 13:22
…umer-changes

# Conflicts:
#	Model/Indexer/Category/ProductIndexer.php
#	Model/Indexer/Product/ProductIndexer.php
#	composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants