allow lambda:TagResource against all resources #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispy101
requested review from
TheOrangePuff and
finnholland
and removed request for
a team
TheOrangePuff
requested changes
Dec 5, 2024
| @@ -148,6 +148,7 @@ export class ServiceDeployIAM extends cdk.Stack { | |||
| "lambda:ListEventSourceMappings", | |||
| "lambda:CreateEventSourceMapping", | |||
| "lambda:DeleteEventSourceMapping", | |||
| "lambda:TagResource", | |||
There was a problem hiding this comment.
Why do we need this on all lambdas? Can we just scope this to named lambdas? (The one above?)
We probably also need the UntagResource permission too
There was a problem hiding this comment.
Thanks for picking this up. Yep, wrong approach. Closing this PR off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.