Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerender Fargate Leading Slash Logic #1411

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

finnholland
Copy link
Collaborator

Description of the proposed changes

  • A change to prerender's logic when it comes to adding a correct leading slash onto the location returned in 301 redirect responses. This affected some prerender instances and led to redirected URLs having doubly-appended responses for example: https://example.com/trains/steam-engines/trains/steam-engines rather than the correct response https://example.com/trains/steam-engines
  • Changed the logic to be a little more clear

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link

@aaronmedina-dev aaronmedina-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finnholland finnholland merged commit 0c37465 into main Dec 2, 2024
1 check passed
@finnholland finnholland deleted the feature/TNT-1579_prerender_leading_slash_logic branch December 2, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants