Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Photometric Stereo] MultiView fusion in Texturing #1590

Open
wants to merge 62 commits into
base: develop
Choose a base branch
from
Open

[Photometric Stereo] MultiView fusion in Texturing #1590

wants to merge 62 commits into from
+1,298 −291

Conversation

jmelou
Copy link
Member

@jmelou jmelou commented Nov 7, 2023 •
edited by fabiencastan
Loading

  • Texturing with output from Photometric Stereo: albedo and normal maps
  • Lighting calibration now supports spherical harmonic lighting

@jmelou jmelou added the feature label Nov 7, 2023
@jmelou jmelou added this to the 3.2.0 milestone Nov 7, 2023
@jmelou jmelou mentioned this pull request Nov 7, 2023
Open
@fabiencastan fabiencastan changed the title [Photometric Stereo] First version of MultiView Photometric Stereo [Photometric Stereo] Photometric Stereo: multiview fusion in Texturing Nov 19, 2023
@fabiencastan fabiencastan changed the title [Photometric Stereo] Photometric Stereo: multiview fusion in Texturing [Photometric Stereo] MultiView fusion in Texturing Nov 19, 2023
@cbentejac cbentejac modified the milestones: 3.2.0, 3.3.0 Nov 24, 2023
jmelou added 17 commits June 4, 2024 00:39
@jmelou @fabiencastan
[mvsUtils] Add error case
c69fc81
@jmelou @fabiencastan
[PS] Add check for metadata
ff17280
@jmelou @fabiencastan
[RTI] Add import from Lp file (RTI)
34e504d
@jmelou @fabiencastan
[PS] Add some breaks
cf5e6b1
@jmelou @fabiencastan
[lightingCalibration] Use perspective hypothesis for brightest point …
ba76946 
…method
@jmelou @fabiencastan
[PS] Typo and break for Lp files
be204b5
@jmelou @fabiencastan
[texturing] Add default filetype (none)
86dbbda
@jmelou @fabiencastan
[multi_view] Change MultiViewParams constructor
d5ea3f8
@jmelou @fabiencastan
[multi-view] Change call to MultiViewParams constructor
a933875
@jmelou @fabiencastan
[texturing] Add margin as parameter
1d36ec5
@jmelou @fabiencastan
[texturing] Allow texturing with normalMaps
2b92ac1
@jmelou @fabiencastan
[texturing] Debug check for pixels that had been visited before
04c2649
@jmelou @fabiencastan
[lightCalibration] Debug read lp and json lightfiles
764d9fd
@jmelou @fabiencastan
[lightingCalibration] Check for metadata
4b32d54
@jmelou @fabiencastan
[lighting calibration] Check for metadata (part. II)
91da93a
@jmelou @fabiencastan
[lighting calibration] Add debug function
944836c 
Write picture on wich is draw the sphere with the estimated lighting
@jmelou @fabiencastan
[ps] Typo
ef4eb5f
jmelou and others added 19 commits June 4, 2024 00:39
@jmelou @fabiencastan
[PS] Lighting Calibration : add functions for calibration from mask
204dae1
@jmelou @fabiencastan
[PS] Lighting calibration : debug perspective estimation
23cf47a
@jmelou @fabiencastan
[PS] Lighting calibration : add needed include
739e34d
@jmelou @fabiencastan
[PS] Lighting calibration : allows use of mask instead of json
3ad576d
@jmelou @fabiencastan
[PS] Lighting calibration : sphere detection file as input instead of…
1de61ad 
… folder
@jmelou @fabiencastan
[PS] Fix png output
a1f4b3f
@jmelou @fabiencastan
[lightingCalibration] Debug ellipse geometry
096a008
@jmelou @fabiencastan
[sphereDetection] Change output
5d50074
@jmelou @fabiencastan
[lightingCalibration] Use CVmask fir ellipse
57409b6
@jmelou @fabiencastan
[LightingCalibration] Ellipse geometry : use OpenCV mask
48fe507 
- debug
- add or change comments
@jmelou @fabiencastan
[lightingCaliration] Forgotten in the previous commit
0b351a3
@jmelou @fabiencastan
[lightingCalibration] Add ellipseGeometry in cmakelist
b2c223c
@jmelou @fabiencastan
[NormalIntegration] Debug normal integration
6f22b17
@jmelou @fabiencastan
[PS - I/O] Add new function for mask reading
202adda 
This new function creates an image which contains, for each pixel,
its position in the mask
@jmelou @fabiencastan
[PS] Debug read of a built model
2ce27f5
@jmelou @fabiencastan
[PS] Debug sub-masks creation
53e245f
@jmelou @fabiencastan
[PS] Correct spelling of "ambient"
e7b2180
@fabiencastan
build fixes
2f0e749
@fabiencastan
[bin] lidarMeshing: build fix related to MultiViewParams constructor …
55719fc 
…changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmelou @fabiencastan @cbentejac