Skip to content

fix: Fix build errors with GCC 15 and optimize third-party library build time #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxy-9602 merged 5 commits into from
Jan 10, 2026
Merged

fix: Fix build errors with GCC 15 and optimize third-party library build time #50

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef42524
chore: update CMake configurations for third-party dependencies
suxiaogang223 Jan 7, 2026
944eab1
chore: update CMake configurations for zstd and arrow dependencies
suxiaogang223 Jan 7, 2026
dbae00a
Merge branch 'main' into fix_build_on_g++15
lucasfang Jan 8, 2026
564c48d
format
suxiaogang223 Jan 9, 2026
63a3cb1
cmake-format
suxiaogang223 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,12 @@ macro(build_fmt)
string(REPLACE "-Werror" "" FMT_CMAKE_CXX_FLAGS ${FMT_CMAKE_CXX_FLAGS})

set(FMT_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DCMAKE_INSTALL_PREFIX=${FMT_PREFIX}
"-DCMAKE_CXX_FLAGS=${FMT_CMAKE_CXX_FLAGS}" "-DCMAKE_C_FLAGS=${FMT_CMAKE_C_FLAGS}")
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_INSTALL_PREFIX=${FMT_PREFIX}
"-DCMAKE_CXX_FLAGS=${FMT_CMAKE_CXX_FLAGS}"
"-DCMAKE_C_FLAGS=${FMT_CMAKE_C_FLAGS}"
-DFMT_TEST=OFF
-DFMT_DOC=OFF)
set(FMT_CONFIGURE CMAKE_ARGS ${FMT_CMAKE_ARGS})
externalproject_add(fmt_ep
URL ${FMT_SOURCE_URL}
Expand Down Expand Up @@ -337,7 +341,8 @@ macro(build_zstd)
-DCMAKE_INSTALL_PREFIX=${ZSTD_PREFIX}
"-DCMAKE_CXX_FLAGS=${ZSTD_CMAKE_CXX_FLAGS}"
"-DCMAKE_C_FLAGS=${ZSTD_CMAKE_C_FLAGS}"
-DZSTD_BUILD_SHARED=OFF)
-DZSTD_BUILD_SHARED=OFF
-DZSTD_BUILD_PROGRAMS=OFF)

set(ZSTD_CONFIGURE SOURCE_SUBDIR "build/cmake" CMAKE_ARGS ${ZSTD_CMAKE_ARGS})
externalproject_add(zstd_ep
Expand All @@ -363,7 +368,8 @@ macro(build_lz4)
"${LZ4_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}lz4${CMAKE_STATIC_LIBRARY_SUFFIX}"
)
set(LZ4_LIBRARIES ${LZ4_STATIC_LIB})
set(LZ4_CMAKE_ARGS ${EP_COMMON_CMAKE_ARGS} -DCMAKE_INSTALL_PREFIX=${LZ4_PREFIX})
set(LZ4_CMAKE_ARGS ${EP_COMMON_CMAKE_ARGS} -DCMAKE_INSTALL_PREFIX=${LZ4_PREFIX}
-DLZ4_BUILD_CLI=OFF -DLZ4_BUILD_LEGACY_LZ4C=OFF)

set(LZ4_CONFIGURE SOURCE_SUBDIR "build/cmake" CMAKE_ARGS ${LZ4_CMAKE_ARGS})
externalproject_add(lz4_ep
Expand Down Expand Up @@ -701,6 +707,9 @@ macro(build_arrow)
set(ARROW_CMAKE_CXX_FLAGS "${EP_CXX_FLAGS} -Wno-error")
set(ARROW_CMAKE_C_FLAGS "${EP_C_FLAGS} -Wno-error")
string(REPLACE "-Werror" "" ARROW_CMAKE_CXX_FLAGS ${ARROW_CMAKE_CXX_FLAGS})
# Fix for thrift Mutex.h missing #include <cstdint> (GCC 15 strictness)
# Use -include to force include cstdint for all C++ files
string(APPEND ARROW_CMAKE_CXX_FLAGS " -include cstdint")

set(ARROW_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/arrow_ep-install")
set(ARROW_HOME "${ARROW_PREFIX}")
Expand Down Expand Up @@ -738,6 +747,9 @@ macro(build_arrow)
-DARROW_DEPENDENCY_USE_SHARED=OFF
-DARROW_BUILD_SHARED=OFF
-DARROW_BUILD_STATIC=ON
-DARROW_BUILD_TESTS=OFF
-DARROW_BUILD_BENCHMARKS=OFF
-DARROW_BUILD_EXAMPLES=OFF
-DARROW_JEMALLOC=OFF
-DARROW_WITH_RE2=OFF
-DARROW_WITH_UTF8PROC=OFF
Expand Down
Loading