Extract interfaces from FileBatchReader to PrefetchFileBatchReader #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfang
force-pushed
the
orc_prefetch
branch
from
5173240 to
a9cdabb
Compare
lucasfang
force-pushed
the
orc_prefetch
branch
from
a9cdabb to
276cf85
Compare
lucasfang
changed the title
lxy-9602
reviewed
Jan 7, 2026
lxy-9602
reviewed
Jan 7, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/paimon/common/reader/prefetch_file_batch_reader_impl.cpp:107
- The constructor parameter is passed by const reference but then moved with std::move. This is problematic because:
- Moving from a const reference is ineffective - it will copy instead of move
- The parameter should either be passed by value (and then moved), or passed by rvalue reference
The constructor should either accept the parameter by value or by rvalue reference to properly transfer ownership.
src/paimon/common/reader/prefetch_file_batch_reader_impl.h:111
- The constructor parameter is declared as const reference but is moved from with std::move on line 107 of the implementation file. This is ineffective - moving from a const reference results in a copy, not a move. The parameter should either be passed by value or by rvalue reference to enable proper move semantics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucasfang
force-pushed
the
orc_prefetch
branch
from
39dceae to
bceadf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation