Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for fix-layout, sticky-layout, floating-layout and width calculation #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sueLan
Copy link

@sueLan sueLan commented May 27, 2021

Fix issues:

  1. support define width as -1; as it is equal to the width of the screen
  2. views with fix-layout, sticky layout or floating layout should stay sticky on the screen when scrolling3

Before Fixing:

Fix Layout

When scrolling, the view in red keep shaking and won't be sticky on the screen.
ezgif com-gif-maker

Sticky layout

The view with sticky layout keeps jumping

stiky-before

Floating layout

Floating view can stay where it should be steadily

floating-layout

After fixing:

Views with these 3 layouts stay stickily on the screen when scrolling

fix

 1.  support define width as -1; as it is equal to the width of the screen
 2. view fix-layout should stay sticky on the screen when scrolling
@CLAassistant
Copy link

CLAassistant commented May 27, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sueLan
❌ Zheng Rongyan


Zheng Rongyan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sueLan sueLan changed the title Fix issues Fix issues for fix-layout and width calculation May 27, 2021
@sueLan sueLan changed the title Fix issues for fix-layout and width calculation Fix issues for fix-layout, sticky-layout, floating-layout and width calculation May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants