Add codegen tests for subroutine local variables #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangsu
reviewed
Dec 23, 2022
Comment on lines
+1784
to
+1794
| if declaration.deferred_expr is not None: | ||
| # This is a hacky way to include the deferred expression in the resulting IR. It's only | ||
| # valid if there are no retsub opcodes anywhere in the subroutine. | ||
|
|
||
| for block in pt.TealBlock.Iterate(actual): | ||
| assert all( | ||
| op.op != pt.Op.retsub for op in block.ops | ||
| ), "retsub present in subroutine, test code to apply deferred expression is no longer valid" | ||
|
|
||
| deferred, _ = declaration.deferred_expr.__teal__(options_v8) | ||
| actual_end.setNextBlock(deferred) |
ahangsu
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child PR to #606
This adds codegen tests to ensure subroutine local variables work properly, both with and without frame pointers.