test: waitFor was badly broken #6359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides being improperly synchronized, its design was flawed. It waited for a channel to appear in `l.waiters`, but that channel didn't last long, and could be missed once synchronization was added. Instead conservatively wait.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6359 +/- ##
==========================================
- Coverage 50.64% 50.48% -0.17%
==========================================
Files 653 653
Lines 110378 110378
==========================================
- Hits 55901 55719 -182
- Misses 51607 51796 +189
+ Partials 2870 2863 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmalouf
approved these changes
Jun 5, 2025
algorandskiy
reviewed
Jun 5, 2025
algorandskiy
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides being improperly synchronized, its design was flawed. It waited for a channel to appear in
l.waiters, but that channel didn't last long, and could be missed once synchronization was added.Instead conservatively wait.
Summary
Test Plan