Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix flaky TestLedgerErrorValidate #6259

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

algorandskiy
Copy link
Contributor

Summary

#6190 introduced retry callbacks and the TestLedgerErrorValidate test with its in-memory ledger was not quite ready for receiving such message that is normal/expected for that kind of concurrent test like this with in-memory ledger.

Test Plan

This is a test fix

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.77%. Comparing base (1d93b27) to head (698d244).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6259      +/-   ##
==========================================
+ Coverage   51.76%   51.77%   +0.01%     
==========================================
  Files         644      644              
  Lines       86506    86506              
==========================================
+ Hits        44777    44792      +15     
+ Misses      38852    38842      -10     
+ Partials     2877     2872       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy requested a review from gmalouf February 20, 2025 20:12
@gmalouf gmalouf merged commit 82221c2 into algorand:master Feb 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants