Incentives: Heartbeat transaction type #13718
jannottireviewdog.yml
on: pull_request
reviewdog-errors
2m 15s
reviewdog-warnings
3m 30s
reviewdog-shellcheck
17s
Annotations
5 errors and 1 warning
|
reviewdog-errors:
test/framework/fixtures/libgoalFixture.go#L479
[Lint Errors] reported by reviewdog 🐶
exported: exported method LibGoalFixture.ConsensusParamsFromVer should have comment or be unexported (revive)
Raw Output:
test/framework/fixtures/libgoalFixture.go:479:1: exported: exported method LibGoalFixture.ConsensusParamsFromVer should have comment or be unexported (revive)
func (f *LibGoalFixture) ConsensusParamsFromVer(cv protocol.ConsensusVersion) config.ConsensusParams {
^
|
|
reviewdog-errors:
ledger/eval/eval.go#L1764
[Lint Errors] reported by reviewdog 🐶
type `headerSource` is unused (unused)
Raw Output:
ledger/eval/eval.go:1764:6: type `headerSource` is unused (unused)
type headerSource interface {
^
|
|
reviewdog-errors:
daemon/algod/api/client/restClient.go#L353
[Lint Errors] reported by reviewdog 🐶
S1012: should use `time.Since` instead of `time.Now().Sub` (gosimple)
Raw Output:
daemon/algod/api/client/restClient.go:353:12: S1012: should use `time.Since` instead of `time.Now().Sub` (gosimple)
time := time.Now().Sub(roundStarted)
^
|
|
reviewdog-errors
reviewdog exited with status code: 1
|
|
reviewdog-warnings:
ledger/apply/heartbeat_test.go#L107
[Lint Warnings] reported by reviewdog 🐶
lint: TestCheapRules: Add missing partition call to top of test. To disable partitioning, add it as a comment: partitiontest.PartitionTest(t) (partitiontest)
Raw Output:
ledger/apply/heartbeat_test.go:107:1: lint: TestCheapRules: Add missing partition call to top of test. To disable partitioning, add it as a comment: partitiontest.PartitionTest(t) (partitiontest)
func TestCheapRules(t *testing.T) {
^
|
|
reviewdog-warnings
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|