Skip to content

feat(sse): add SSE server command #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat(sse): add SSE server command #8

wants to merge 7 commits into from

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Apr 17, 2025

What

  • extract common code between stdio and sse servers
  • add start-sse-server command to CLI
  • add config example with gateway to README

Todo

  • We could use some more modern server like HonoJS
  • OAuth should be done at the server level, not at the MCP app level, to link auth to the user session
  • User sessions should be handled by a Redis or similar

@Fluf22 Fluf22 self-assigned this Apr 17, 2025
@Fluf22 Fluf22 requested a review from sarahdayan April 17, 2025 13:55
@Fluf22 Fluf22 marked this pull request as draft April 18, 2025 07:36
@Fluf22 Fluf22 mentioned this pull request Apr 18, 2025
@seafoox
Copy link
Member

seafoox commented Apr 30, 2025

OAuth should be done at the server level, not at the MCP app level, to link auth to the user session

Agree would be great if we could obtain the accessToken connecting to the website, and then setting that one via an ENV variable. In a context like n8n, that would allow to deploy the MCP server one, and declare multiple instance via n8n nodes. Each instance potentially pointing to its own Algolia account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants